Make card() a custom element
#1009
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
card-custom-element
branch
from
ae9bef7
to
430537d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal take on having
card()leverage the benefits of custom elements (namely,connectedCallback()anddisconnectedCallback()hooks). This allows us to immediately get rid of some hacky initialization logic, as well as putting us in a better place to handle situations like #1005.The largest risk with this change is that we're introducing a container around the actual
<div class="card">container. This has the outside chance of breaking some CSS, and maybe some R/Python code digging into$children/.children, but it seems better to rip that band-aid now vs later. We'll also need to update Quarto's dashboarding code to wrap<div class="card">markup into a<bslib-card>container.I don't think we should take on this PR for this immediate release, but ideally we'll do it immediately after and as a precursor to #1005.