-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
high level design documentation #44
Draft
alex-dukhno
wants to merge
6
commits into
rsocket:develop
Choose a base branch
from
alex-dukhno:high-level-design-doc
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I haven't added it to the design doc, but I have an idea of describing spec cases in the following way (I don't know if it is possible to write such DSL in Kotlin but ...): @Case
fun `server must reject connection with ERROR[INVALID_SETUP]`() {
send(Frame.setup(streamId: NON_ZERO))
.to(server)
.expect(Frame.error(streamId: 0, errorCode: INVALID_SETUP))
} If server acts properly upon the case then TCK should report like: [x] server must reject connection with ERROR[INVALID_SETUP] if server doesn't then (e.g.) [-] server must reject connection with ERROR[INVALID_SETUP]
[-] server respond with streamId: 1
[-] errorCode was UNSUPPORTED_SETUP |
OlegDokuka
requested changes
Apr 12, 2020
Co-Authored-By: Oleh Dokuka <[email protected]>
Co-Authored-By: Oleh Dokuka <[email protected]>
Co-Authored-By: Oleh Dokuka <[email protected]>
What is the purpose of this doc? Is it to describe the TCK goals/design/implementation details or is it for a different purpose? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README
For Contributors