Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

high level design documentation #44

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

alex-dukhno
Copy link
Collaborator

@alex-dukhno alex-dukhno commented Apr 10, 2020

@alex-dukhno alex-dukhno self-assigned this Apr 10, 2020
@alex-dukhno alex-dukhno requested a review from OlegDokuka April 11, 2020 06:05
@alex-dukhno alex-dukhno marked this pull request as ready for review April 11, 2020 06:05
@alex-dukhno alex-dukhno requested a review from whyoleg April 11, 2020 06:06
@alex-dukhno
Copy link
Collaborator Author

I haven't added it to the design doc, but I have an idea of describing spec cases in the following way (I don't know if it is possible to write such DSL in Kotlin but ...):

@Case
fun `server must reject connection with ERROR[INVALID_SETUP]`() {
    send(Frame.setup(streamId: NON_ZERO))
        .to(server)
        .expect(Frame.error(streamId: 0, errorCode: INVALID_SETUP))
}

If server acts properly upon the case then TCK should report like:

[x] server must reject connection with ERROR[INVALID_SETUP]

if server doesn't then (e.g.)

[-] server must reject connection with ERROR[INVALID_SETUP]
    [-] server respond with streamId: 1
    [-] errorCode was UNSUPPORTED_SETUP

doc/10-04-2020-High-Level-Design.md Outdated Show resolved Hide resolved
doc/10-04-2020-High-Level-Design.md Outdated Show resolved Hide resolved
doc/10-04-2020-High-Level-Design.md Outdated Show resolved Hide resolved
doc/10-04-2020-High-Level-Design.md Outdated Show resolved Hide resolved
@OlegDokuka
Copy link
Member

What is the purpose of this doc? Is it to describe the TCK goals/design/implementation details or is it for a different purpose?

@alex-dukhno alex-dukhno marked this pull request as draft May 26, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants