Upgrade to Angular 10 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two commits here, I can redo the pull request if you like, as the first wasn't needed in the end, but I've left it as I see it as an improvement nonetheless. I have not tried incrementing versions as I'm not sure of the flow using
ng-packagr.First commit
I tried running
ng updateand it complained about bootstrap missing 2 dependencies (jQuery and hammerjs, I think). I took a look and saw that bootstrap wasn't really required in the project, so I copied over the required bootstrap SCSS into the test component and global styles and removed bootstrap as a dependency. I now realise they were probably left out by intention, as bootstrap's JavaScript was never used, but still, this simplifies maintenance.Second commit
Then I tried to upgrade again, this time it was giving out about
zone.jshaving to be upgraded from10.x.xto11.x.x, which is odd because angular 10 uses the same10.x.xas 9. However, I've seen this exact issue migrating other projects from 9 to 10, and in my experience the newer version is fine. So I ranng update --all --forceand it upgraded almost all packages.Tests
It's passing all tests in Karma and is building fine. When imported into a project the Validator interfaces now match, so the Angular 10 compatibility problem appears to be fixed.