Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators broken since ivy #38

Closed
shprink opened this issue May 22, 2020 · 3 comments
Closed

Validators broken since ivy #38

shprink opened this issue May 22, 2020 · 3 comments

Comments

@shprink
Copy link

shprink commented May 22, 2020

Hello,

I have upgraded Angular and your lib to v9 and now the equalTo validator breaks the app.

Here is the example with and without Ionic: https://stackblitz.com/edit/angular-ivy-ipk5rp

remove [equalTo] and it will work

@bjornharvold
Copy link

Duplicate of #33

@suhailkc
Copy link

suhailkc commented Aug 6, 2020

@shprink
I have the same issue using equalTo and notEqualTo validators.

<input class="form-control" type="text" placeholder="password" ngModel name="password" #password="ngModel"/>
<input class="form-control mt-2" type="text" placeholder="re-enter password" ngModel name="equalToPassword" #equalToPassword="ngModel" [equalTo]="password"/>

<p *ngIf="equalToPassword?.errors?.equalTo">equalTo error</p>

Error when ng build --prod :

Type 'NgModel' is missing the following properties from type 'FormControl': setValue, patchValue, registerOnChange, registerOnDisabledChange, and 28 more.

Versions:
Angular: 10.0.7
ngx-custom-validators: ^8.0.0 (downgraded from ^9.1.0 because of error in Angular 10)

Could anybody know the solution?

@rsaenen
Copy link
Owner

rsaenen commented Oct 14, 2020

Released with 10.0.0, please reopen the issue if necessary.

@rsaenen rsaenen closed this as completed Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants