Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashdir option to ccache plugin #1399

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

belegdol
Copy link
Contributor

@belegdol belegdol commented Jul 5, 2024

Setting it to false allows ccache to be shared across different package NEVRs, but the debuginfo files may contain incorrect information in exchange:

https://ccache.dev/manual/4.10.html#config_hash_dir

Fixes #1395

@pep8speaks
Copy link

pep8speaks commented Jul 5, 2024

Hello @belegdol! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-07-12 14:56:31 UTC

@praiskup
Copy link
Member

Can you also please squash the commits? Otherwise LGTM

Setting it to false allows ccache to be shared across different package NEVRs, but the debuginfo files may contain incorrect information in exchange:
https://ccache.dev/manual/4.10.html#config_hash_dir
@xsuchy
Copy link
Member

xsuchy commented Jul 16, 2024

All fine. I am ignoring the one failing test that is not caused by this PR. Merging. Thank you.

@xsuchy xsuchy merged commit 7fbd9bb into rpm-software-management:main Jul 16, 2024
20 of 21 checks passed
@belegdol belegdol deleted the hashdir branch July 16, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: improve ccache plugin usability by enabling cache hits across package NEVRs
4 participants