Merge remote-tracking branch 'upstream/develop' into issue-1275

CONTRIBUTING.md

@@ -17,16 +17,26 @@ Read the documentation on setting up your local development environment
 Read how to submit a pull request [here](https://docs.rowy.io/contributing).
 
 To get familiar with the project,
-[good first issues](https://github.com/rowyio/rowy/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) is a good place
-to start.
+[good first issues](https://github.com/rowyio/rowy/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
+is a good place to start.
 
 ## Working on existing issues
 
-
-
-Before you get started working on an [issue](https://github.com/rowyio/rowy/issues), please make sure to share that you are working on it by commenting on the issue and posting a message on #contributions channel in Rowy's [Discord](https://rowy.io/discord). The maintainers will then assign the issue to you after making sure any relevant information or context in addition is provided before you can start on the task.
-
-Once you are assigned a task, please provide periodic updates or share any questions or roadblocks on either discord or the Github issue, so that the commmunity or the project maintainers can provide you any feedback or guidance as needed. If you are inactive for more than 1-2 week on a issue that was assigned to you, then we will assume you have stopped working on it and we will unassign it from you - so that we can give a chance to others in the community to work on it.
+Before you get started working on an
+[issue](https://github.com/rowyio/rowy/issues), please make sure to share that
+you are working on it by commenting on the issue and posting a message on
+#contributions channel in Rowy's
+[Discord](https://discord.com/invite/fjBugmvzZP). The maintainers will then
+assign the issue to you after making sure any relevant information or context in
+addition is provided before you can start on the task.
+
+Once you are assigned a task, please provide periodic updates or share any
+questions or roadblocks on either discord or the Github issue, so that the
+commmunity or the project maintainers can provide you any feedback or guidance
+as needed. If you are inactive for more than 1-2 week on a issue that was
+assigned to you, then we will assume you have stopped working on it and we will
+unassign it from you - so that we can give a chance to others in the community
+to work on it.
 
 ## File a feature request
 
@@ -35,10 +45,9 @@ create a new issue using
 [Feature Request Template](https://github.com/rowyio/rowy/issues/new?assignees=&labels=&template=feature_request.md)
 to share your idea. If you are working on this to contribute to the project,
 then let others in the community and project maintainers know by posting on
-#contributions channel in Rowy's
-[Discord](https://rowy.io/discord). This allows others in the
-community and the maintainers a chance to provide feedback and guidance before
-you spend time working on it.
+#contributions channel in Rowy's [Discord](https://rowy.io/discord). This allows
+others in the community and the maintainers a chance to provide feedback and
+guidance before you spend time working on it.
 
 ## Report an issue
 

README.md

@@ -55,6 +55,7 @@ Low-code for Firebase and Google Cloud.
     </td>
     </tr>
 </table> -->
+
 https://user-images.githubusercontent.com/307298/157185793-f67511cd-7b7b-4229-9589-d7defbf7a63f.mp4
 
 <!-- <img width="85%" src="https://firebasestorage.googleapis.com/v0/b/rowyio.appspot.com/o/publicDemo%2FRowy%20Website%20Video%20GIF%20Small.gif?alt=media&token=3f699a8f-c1f2-4046-8ed5-e4ff66947cd8" />
@@ -98,8 +99,10 @@ https://user-images.githubusercontent.com/307298/157185793-f67511cd-7b7b-4229-95
 
 ## Quick guided install
 
-Set up Rowy on your Google Cloud Platform project with this easy deploy button. Your
-data and cloud functions stay on your own Firestore/GCP and is managed via a cloud run instance that operates exclusively on your GCP project. So we do do not access or store any of your data on Rowy.
+Set up Rowy on your Google Cloud Platform project with this easy deploy button.
+Your data and cloud functions stay on your own Firestore/GCP and is managed via
+a cloud run instance that operates exclusively on your GCP project. So we do do
+not access or store any of your data on Rowy.
 
 [<img width="200" alt="Guided quick start button" src="https://user-images.githubusercontent.com/307298/185548050-e9208fb6-fe53-4c84-bbfa-53c08e03c15f.png">](https://rowy.app/)
 
@@ -112,12 +115,17 @@ You can find the full documentation with how-to guides and templates
 
 ## Manual Install
 
-We recommend the [quick guided install](https://github.com/rowyio/rowy#quick-guided-install) option above. Manual install option is only recommended if you want to develop and contribute to the project. Follow this [guide](https://docs.rowy.io/setup/install#option-2-manual-install) for manual setup.
+We recommend the
+[quick guided install](https://github.com/rowyio/rowy#quick-guided-install)
+option above. Manual install option is only recommended if you want to develop
+and contribute to the project. Follow this
+[guide](https://docs.rowy.io/setup/install#option-2-manual-install) for manual
+setup.
 
 ## Roadmap
 
-[View our roadmap](https://roadmap.rowy.io/) on Rowy - Upvote,
-downvote, share your thoughts!
+[View our roadmap](https://roadmap.rowy.io/) on Rowy - Upvote, downvote, share
+your thoughts!
 
 If you'd like to propose a feature, submit an issue
 [here](https://github.com/rowyio/rowy/issues/new?assignees=&labels=&template=feature_request.md&title=).

src/App.tsx

@@ -23,6 +23,7 @@ import useKeyPressWithAtom from "@src/hooks/useKeyPressWithAtom";
 
 import TableGroupRedirectPage from "./pages/TableGroupRedirectPage";
 import SignOutPage from "@src/pages/Auth/SignOutPage";
+import ProvidedArraySubTablePage from "./pages/Table/ProvidedArraySubTablePage";
 
 // prettier-ignore
 const AuthPage = lazy(() => import("@src/pages/Auth/AuthPage" /* webpackChunkName: "AuthPage" */));
@@ -134,6 +135,27 @@ export default function App() {
                     }
                   />
                 </Route>
+                <Route path={ROUTES.arraySubTable}>
+                  <Route index element={<NotFound />} />
+                  <Route
+                    path=":docPath/:subTableKey"
+                    element={
+                      <Suspense
+                        fallback={
+                          <Backdrop
+                            key="sub-table-modal-backdrop"
+                            open
+                            sx={{ zIndex: "modal" }}
+                          >
+                            <Loading />
+                          </Backdrop>
+                        }
+                      >
+                        <ProvidedArraySubTablePage />
+                      </Suspense>
+                    }
+                  />
+                </Route>
               </Route>
             </Route>
 

src/assets/icons/ArraySubTable.tsx

@@ -0,0 +1,9 @@
+import SvgIcon, { SvgIconProps } from "@mui/material/SvgIcon";
+
+export function ArraySubTable(props: SvgIconProps) {
+  return (
+    <SvgIcon {...props}>
+      <path d="M1 4C1 2.34315 2.34315 1 4 1H18C19.6569 1 21 2.34315 21 4V11H19H12V15V17H4C2.34315 17 1 15.6569 1 14V4ZM10 15V11H3V14C3 14.5523 3.44772 15 4 15H10ZM12 9H19V5H12V9ZM10 5H3V9H10V5ZM15 13H14V14V22V23H15H17V21H16V15H17V13H15ZM21 13H22V14V22V23H21H19V21H20V15H19V13H21Z" />
+    </SvgIcon>
+  );
+}

src/atoms/projectScope/project.ts

@@ -133,3 +133,16 @@ export const FunctionsIndexAtom = atom<FunctionSettings[]>([]);
 export const updateFunctionAtom = atom<
   UpdateCollectionDocFunction<FunctionSettings> | undefined
 >(undefined);
+
+export interface ISecretNames {
+  loading: boolean;
+  secretNames: null | string[];
+}
+
+export const secretNamesAtom = atom<ISecretNames>({
+  loading: true,
+  secretNames: null,
+});
+export const updateSecretNamesAtom = atom<
+  ((clearSecretNames?: boolean) => Promise<void>) | undefined
+>(undefined);

src/atoms/projectScope/ui.ts

@@ -147,10 +147,6 @@ export const tableSettingsDialogSchemaAtom = atom(async (get) => {
 /** Open the Get Started checklist from anywhere */
 export const getStartedChecklistAtom = atom(false);
 
-/** Persist the state of the add row ID type */
-export const tableAddRowIdTypeAtom = atomWithStorage<
-  "decrement" | "random" | "custom"
->("__ROWY__ADD_ROW_ID_TYPE", "decrement");
 /** Persist when the user dismissed the row out of order warning */
 export const tableOutOfOrderDismissedAtom = atomWithStorage(
   "__ROWY__OUT_OF_ORDER_TOOLTIP_DISMISSED",

src/atoms/tableScope/rowActions.test.ts

@@ -494,7 +494,11 @@ describe("deleteRow", () => {
     } = renderHook(() => useSetAtom(deleteRowAtom, tableScope));
     expect(deleteRow).toBeDefined();
 
-    await act(() => deleteRow(TEST_COLLECTION + "/row2"));
+    await act(() =>
+      deleteRow({
+        path: TEST_COLLECTION + "/row2",
+      })
+    );
 
     const {
       result: { current: tableRows },
@@ -510,7 +514,11 @@ describe("deleteRow", () => {
     } = renderHook(() => useSetAtom(deleteRowAtom, tableScope));
     expect(deleteRow).toBeDefined();
 
-    await act(() => deleteRow(TEST_COLLECTION + "/rowLocal2"));
+    await act(() =>
+      deleteRow({
+        path: TEST_COLLECTION + "/rowLocal2",
+      })
+    );
 
     const {
       result: { current: tableRows },
@@ -527,9 +535,9 @@ describe("deleteRow", () => {
     expect(deleteRow).toBeDefined();
 
     await act(() =>
-      deleteRow(
-        ["row1", "row2", "row8"].map((id) => TEST_COLLECTION + "/" + id)
-      )
+      deleteRow({
+        path: ["row1", "row2", "row8"].map((id) => TEST_COLLECTION + "/" + id),
+      })
     );
 
     const {
@@ -548,7 +556,11 @@ describe("deleteRow", () => {
     } = renderHook(() => useSetAtom(deleteRowAtom, tableScope));
     expect(deleteRow).toBeDefined();
 
-    await act(() => deleteRow(generatedRows.map((row) => row._rowy_ref.path)));
+    await act(() =>
+      deleteRow({
+        path: generatedRows.map((row) => row._rowy_ref.path),
+      })
+    );
 
     const {
       result: { current: tableRows },
@@ -563,7 +575,11 @@ describe("deleteRow", () => {
     } = renderHook(() => useSetAtom(deleteRowAtom, tableScope));
     expect(deleteRow).toBeDefined();
 
-    await act(() => deleteRow("nonExistent"));
+    await act(() =>
+      deleteRow({
+        path: "nonExistent",
+      })
+    );
 
     const {
       result: { current: tableRows },
@@ -578,7 +594,11 @@ describe("deleteRow", () => {
     } = renderHook(() => useSetAtom(deleteRowAtom, tableScope));
     expect(deleteRow).toBeDefined();
 
-    await act(() => deleteRow("nonExistent"));
+    await act(() =>
+      deleteRow({
+        path: "nonExistent",
+      })
+    );
 
     const {
       result: { current: tableRows },