Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rosgraph_manipulator to a separate repo #42

Open
chcorbato opened this issue Aug 5, 2020 · 3 comments
Open

Move rosgraph_manipulator to a separate repo #42

chcorbato opened this issue Aug 5, 2020 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@chcorbato
Copy link
Member

Move rosgraph_manipulator to a separate repo, because it is a metacontrol asset that should be "experiment/system" agnostic, but platform specific for ROS1

@ipa-nhg
Copy link
Member

ipa-nhg commented Oct 7, 2020

We, at IPA, have a potential new use for the rosgraph_manipulator, is it possible to make it generic? For example take the list of nodes to be killed from a yaml file.

make it sense for you @marioney ? We can also support/send a suggestion as PR

@marioney
Copy link
Member

marioney commented Oct 8, 2020

is it possible to make it generic? For example take the list of nodes to be killed from a yaml file.

I think that's a good idea. And of course we would really appreciate your support on this.

We can also support/send a suggestion as PR

I think a PR will be good, so we can discuss on the details for the change there

As of now, we're only killing the move_base node, but actually, the kill_node function accepts the node name and namespace, so it's just a matter of changing the way it's used.

@ipa-nhg
Copy link
Member

ipa-nhg commented Oct 23, 2020

Move rosgraph_manipulator to a separate repo: ✔️ done -> meta-control/mc_rosgraph_manipulator#2

About how to make it generic I will open a new issue for mc_rosgraph_manipulator to discuss potential solutions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants