Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create code for Objective Error observer #40

Closed
marioney opened this issue May 22, 2020 · 6 comments
Closed

Create code for Objective Error observer #40

marioney opened this issue May 22, 2020 · 6 comments

Comments

@marioney
Copy link
Member

Observer for Objective error: needed for scenarios 3 in yellow table

  • Should check if there's an error when the route is not available.
    - Path length 0
  • Check move_base/result topic
  • Should check if the robot is blocked (not moving after X seconds)

Objective should publish: "true" if there's an error
"false" if the system is running OK.

Also create another another observer on the rosgraph_observer to send it to the reasoner

https://docs.google.com/document/d/1BaOxo7_WQ2fUUUWIyw5pE_K_q6sErQJXge5VeFjyhgQ/edit#bookmark=id.4rg7xmp249au

@marioney
Copy link
Member Author

@darkobozhinoski @chcorbato A quick question, if an error is received, the message is sent but when should we clear the objective error (change the error message to false again)

Options are:

  • When a new goal (reconfiguration) is received
  • Only send the error one time
  • Keep the error for X seconds

@marioney
Copy link
Member Author

Done in 87ad4e0 and rosin-project/rosgraph_monitor@674fc29

* Keep the error for X seconds

For now the error message is published for 1 sec.

@chcorbato
Copy link
Member

@darkobozhinoski @chcorbato A quick question, if an error is received, the message is sent but when should we clear the objective error (change the error message to false again)

I am not sure.

Options are:

  • When a new goal (reconfiguration) is received
  • Only send the error one time
  • Keep the error for X seconds

Nice analysis. I would say the error should be reported while the condition that triggered it continuous. If the topics whose values cause it keep reporting the same values, keep sending the error. But it is just an idea.

@marioney
Copy link
Member Author

marioney commented May 24, 2020

Done in 87ad4e0 and rosin-project/rosgraph_monitor@674fc29

@chcorbato should we close this?

@chcorbato
Copy link
Member

I think I remember seeing the error in the printout of the message received by mros1_reasoner with "ojbective" misspelled. A part from that, yes, you can close it.

@chcorbato
Copy link
Member

chcorbato commented Sep 9, 2020

This issue was completed, improvement tracked in meta-control/mc_mros_reasoner#94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants