Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle #38

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Bundle #38

merged 3 commits into from
Jun 26, 2023

Conversation

samestep
Copy link
Contributor

@samestep samestep commented Jun 25, 2023

To help more accurately assess efforts like #37, this PR adds a new private @rose-lang/site package that uses Vite to bundle for the browser, so we can see how big that bundle is (both with and without gzip) by looking at Vite's build output:

yarn workspace @rose-lang/site build
yarn workspace v1.22.19
yarn run v1.22.19
$ vite build
vite v4.3.9 building for production...
✓ 14 modules transformed.
dist/index.html                  0.33 kB │ gzip:  0.24 kB
dist/assets/index-09f82714.js  227.93 kB │ gzip: 79.93 kB
✓ built in 186ms
✨  Done in 0.40s.
✨  Done in 0.54s.

I initially tried just using library mode instead of wrapping it in a webpage, but because of vitejs/vite#4454, that prevents us from seeing the benefits of better asset handling like #39. This is fine anyways though, because we'll want to have a site eventually.

I copied some of the tsconfig.json changes from commit cc3560d in #9, then pulled most of it out into a new tsconfig.json file at the package root that we can share among all our packages.

@samestep samestep requested review from ravenrothkopf and removed request for ravenrothkopf June 25, 2023 11:47
@samestep samestep marked this pull request as draft June 25, 2023 12:01
@samestep samestep marked this pull request as ready for review June 25, 2023 12:34
@samestep samestep requested a review from ravenrothkopf June 25, 2023 12:37
@samestep samestep merged commit d42e38f into main Jun 26, 2023
@samestep samestep deleted the bundle branch June 26, 2023 12:27
@samestep samestep mentioned this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants