Allow compiled functions to share memory #125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently every function created using
compile
allocates its own memory. This causes problems in applications that callcompile
many times, because current browsers do not consistently track the amount of allocated Wasm memory with their garbage collectors, and so out-of-memory errors can easily result even if the amount of memory needed at a given time is relatively small.This PR addresses the issue by allowing the
compile
function to take in an optionalmemory
parameter, which it will use (and grow if necessary) if provided, instead of always allocating a new memory.