Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated spin_until_future_complete (take 2) #541

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Apr 2, 2024

Reverts #504, so it un-reverts #499.

Replaces #505

Requires ros2/rclcpp#2475
Requires ros2/rclpy#1268

Part of ros2/rclcpp#2475

Co-authored-by: Hubert Liberacki <[email protected]>
Signed-off-by: Hubert Liberacki <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
@christophebedard
Copy link
Member Author

As per the discussion in ros2/rclcpp#2475 (comment), we will not be doing this. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant