Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cve into assimp #1258

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rviz_assimp_vendor/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ set(ON 1)

# TODO: Switch to version range in find_package in CMake 3.19
find_package(assimp QUIET)
if(NOT assimp_FOUND OR "${assimp_VERSION}" VERSION_LESS 5.2.0)
if(NOT assimp_FOUND OR "${assimp_VERSION}" VERSION_LESS 5.4.2)
set(assimp_FOUND FALSE)
endif()

Expand All @@ -38,7 +38,7 @@ endif()
ament_vendor(assimp_vendor
SATISFIED ${assimp_FOUND}
VCS_URL https://github.com/assimp/assimp.git
VCS_VERSION v5.3.1
VCS_VERSION v5.4.2
CMAKE_ARGS
-DASSIMP_BUILD_ASSIMP_TOOLS:BOOL=OFF
-DASSIMP_BUILD_TESTS:BOOL=OFF
Expand Down