Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointStampedDisplay: Ignore incoming messages if disabled #1036

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 16, 2023

Related with this PR ros-visualization/rviz#1765 in RViz for ROS 1

@ahcorde ahcorde self-assigned this Aug 16, 2023
@clalancette
Copy link
Contributor

Reading ros-visualization/rviz#1764 , it looks like the problem is with messages that have arrived, but not yet processed, when the plugin is disabled. Fixing that problem seems worthwhile.

However, I'm not totally convinced that this is the way to do it. Reading ros-visualization/rviz#1764 (comment) , it looks like that particular fix did not fix the issue in Noetic (though it seems to have fixed it in Melodic, strangely). So while I think this is an OK fix to put in, I think we should also track down what the fix to Noetic was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants