[backport] Use modern cmake targets to avoid absolute paths to appear in binary … #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…archives (ros2#160) * Use FindPython3 Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Make link libraries private when possible to avoid having to export dependencies Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Use Python3::Numpy Signed-off-by: Ivan Santiago Paunovic <[email protected]>
clalancette
reviewed
Jul 22, 2024
There was a problem hiding this comment.
I have to say that I'm very worried about doing this. I've been poking at this for months in #204 (though that has a different goal), and the whole system here is tricky. For a stable release, I think this is going to be dangerous and may have unwanted side-effects. For those reasons, my opinion is that we should not take this into humble at this time.
@sloretz What's your take on this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…archives (#160)
Use FindPython3
Make link libraries private when possible to avoid having to export dependencies
Use Python3::Numpy