Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static typing for Message, Services, and Actions #206

Open
wants to merge 55 commits into
base: rolling
Choose a base branch
from
Open

Static typing for Message, Services, and Actions #206

wants to merge 55 commits into from

Conversation

InvincibleRMC
Copy link

@InvincibleRMC InvincibleRMC commented Mar 15, 2024 •
edited
Loading

Adds static typing to generated messages. Built off #205. Closes #157.

@InvincibleRMC
explicit export and py.typed
f81e023 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Fix line lengths
2f99351 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Fix hanging indent
05761d8 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Improve typing
9807b07 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Fix subscription error
288ba5d 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC InvincibleRMC marked this pull request as draft March 15, 2024 07:12
@InvincibleRMC
Copy link
Author

Still need to fix a circular import issue.

@InvincibleRMC
Tests complete
9aad27a 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Fewer flake8
2822852 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC InvincibleRMC marked this pull request as ready for review March 15, 2024 16:35
InvincibleRMC and others added 18 commits March 15, 2024 13:36
@InvincibleRMC
Fix typing import error
118b9ef 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Update _msg.py.em
af91451 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Constructor typing refactor
153a6d7 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Update _msg.py.em
6a147a7 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
remove structure_needs_at_least_one_member
946381a 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Add actual numpy type annotations
956fe0a 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Add None
ae98901 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Add types to __prepare__ args
8d06b8c 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Default type annotations
ad14966 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Constant type annotations
48def6b 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Type constants
8458b38 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
SLOT_TYPES type
9f80bcc 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
small refactor
4b2f72c 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Add Protocol
a412da2 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Blank lines for flake8
86d8a97 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Remove Literal for better 3.6 support
5d839f4 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Better return types
1aef88a 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Move TYPE_CHECKING import
468c8f5 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Literal Clean up
af7463a 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
remove forward reference
bb4ca22 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
remove string wrapper
b0667d2 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
replace quotes with '
3fca5b1 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
add mypy test
4a8fdf3 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
add mypy test
68629fa 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC InvincibleRMC changed the title Improve message types. Static typing for Message, Services, and Actions Sep 4, 2024
@InvincibleRMC
resolve truthy assert
f1d38a7 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
move Literal import
a5b8d41 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
update string literals
1886955 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
fix Literal float
d3acf35 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Add some types into rosidl_generator_py
9d10ab5 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
type_support import
33d126a 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
remove file
829c25b 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
fix byte litearls
9b95b02 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
remove ovveride
010db3f 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
fix __prepare__
ffc1b37 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
fix metacls
5752835 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
remove ByteString from isinstance
ad8fd40 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
import error
e7a2ed6 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
switch typing improt
f1966c7 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
move Literal import
95c8e52 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
match getter and setter
375cc73 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
fix numpy types
576fe24 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
resolve all()
381d1e1 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
fix mypy error
41cc561 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
type ignore around mypy#3004
6e357c3 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
revert specifc getter type
dd5c3e9 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Use Any to avoid mypy#3004
b6bc52c 
Signed-off-by: Michael Carlstrom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quarkytale quarkytale Awaiting requested review from quarkytale quarkytale is a code owner

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python type annotation
3 participants
@InvincibleRMC @haudren-woven @sloretz