Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for rosbag2_cpp serialization converter #1814

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Bugfix for rosbag2_cpp serialization converter #1814

merged 7 commits into from
Sep 25, 2024

Commits on Sep 21, 2024

  1. Bugfix for rosbag2 serialization converter 

    - Use rmw specific type support for rmw_serilize{deserialize} function
calls.
Note: It is ok for CycloneDDS to use introspection type support for
rmw_serilize{deserialize} functions. However, for FastRTPS it must be
rmw specific type support. e.g. rosidl_typesupport_cpp. Fix works for
both CycloneDDS and FastRTPS rmw.

Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    7135f94 View commit details
    Browse the repository at this point in the history

  2. Add test coverage for default rmv serialization format converter 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    28deb24 View commit details
    Browse the repository at this point in the history

  3. Run test_serialization_converter for each rmw implementation 

    - Rationale: To make sure that the default serialization converter can
serialize and deserialize messages with all supported rmw
implementations. Since it uses rmw specific functions for serialization
and deserialization inside.

Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    fea7142 View commit details
    Browse the repository at this point in the history

  4. Address uncrustify formating warnings 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    c35cca3 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Enable sanitizer by default 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    7241963 View commit details
    Browse the repository at this point in the history

  2. Address Windows build warnings 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    e1c0cf9 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Revert "Enable sanitizer by default" 

    This reverts commit 7241963.

Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6351583 View commit details
    Browse the repository at this point in the history