Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to load a ros param file for all nodes #778

Open
ckurtz22 opened this issue Nov 10, 2022 · 4 comments
Open

No way to load a ros param file for all nodes #778

ckurtz22 opened this issue Nov 10, 2022 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ckurtz22
Copy link

ckurtz22 commented Nov 10, 2022


Feature request

Feature description

ROS2 has no functionality for loading a parameter file that contains parameters for multiple nodes. This was easily doable in ROS1 and there is no reason it should not be possible in ROS2. For example, parameter file named "params.yaml" contains the following:

/my_node1:
  ros__parameters:
    param1: 1.0
    param2: "test"
/my_node2:
  ros__parameters:
    param3: 73

and then running ros2 param load params.yaml would apply the relevant parameters to the nodes named /my_node1 and /my_node2

Implementation considerations

It makes no sense why this would not be allowed under the ROS2 framework, considering the parameter file already requires nodes to be explicitly named.

@fujitatomoya fujitatomoya added enhancement New feature or request help wanted Extra attention is needed labels Nov 10, 2022
@fujitatomoya
Copy link
Collaborator

right, this cannot be done with current ros2 param command, since it requires node_name in the argument. I think this feature is reasonable.

CC: @ros2/team

@RFRIEDM-Trimble
Copy link
Contributor

This sounds like a fun one, I'd like to take the work if the team is happy with the modification. Seems straightforward enough.

@reinzor
Copy link

reinzor commented Oct 27, 2023

Any updates on this; we could help with the implementation if this suggested feature is desired.

@fujitatomoya
Copy link
Collaborator

No, i do not think anybody working on this. feature sounds good to me, but it could not be so straight-forward. currently it knows which node to set the parameters because user specifies so, but this requires to parse the parameter file to which node to call the parameter service (including wildcard), besides needs to create ParameterClient for each of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants