Add more explanation about PushRosNamespace action (backport #4679) #4765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Add more explanation about PushRosNamespace action * make PushROSNamespace comform to PEP8 Co-authored-by: thomasung <[email protected]> (cherry picked from commit a2f34a7)
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/10970112114/artifacts/1961151918. To view the resulting site:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to work with namespaces, I found myself adding the
PushRosNamespace()action at the end of my action list. That made me spend a lot of time trying to understand why my namespace where not applied. Only to see that PushRosNamespace would only work for the actions called after.Therefore, I thought it would be relevant to add this information to the documentation if any other developer encounter this issue.
Thanks for giving me feedback on this PR, hope you're having a nice day !
This is an automatic backport of pull request #4679 done by Mergify.