Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch large project tutorial fix (backport #4454) #4662

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 21, 2024

Fixes partly this issue from the jazzy tutorial testing: osrf/ros2_test_cases#1151

I can't really figure out why the carrot1 frame is not showing up other than that it is forgotten in the launch file? I still get this error:

[turtle_tf2_listener-6] [INFO] [1715366094.127739162] [listener]: Could not transform turtle2 to carrot1: "carrot1" passed to lookupTransform argument source_frame does not exist.

I could consider fixing this by adding the carrot1 somewhere... or removing all notion of carrot1 all together? I've started a proposal in this ticket to reshape the launch tutorials anyway... #4453.

Anyway, this should at least target Rolling and Jazzy documents.


This is an automatic backport of pull request #4454 done by Mergify.

* remove instruction that will fail, inconsistency

* add rviz folder in setup.py

* add warning for missing environment variable

* Update source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst

Signed-off-by: Kimberly McGuire <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit 2a9b2fc)
Copy link

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/10492078644/artifacts/1837863988.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4662/index.html in your favorite browser

@clalancette clalancette merged commit 3e0aa77 into jazzy Aug 21, 2024
4 checks passed
@clalancette clalancette deleted the mergify/bp/jazzy/pr-4454 branch August 21, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants