Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast-DDS uses SHM transport by default, so network traffic cannot be … #3683

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

fujitatomoya
Copy link
Collaborator

@fujitatomoya
Copy link
Collaborator Author

@MiguelCompany if you have time, can you take a look?

Copy link
Contributor

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fujitatomoya
Copy link
Collaborator Author

@Yadunund can you review this?

Signed-off-by: Tomoya.Fujita <[email protected]>
@fujitatomoya
Copy link
Collaborator Author

@Yadunund requesting another review, thanks!

Signed-off-by: Tomoya.Fujita <[email protected]>
@fujitatomoya
Copy link
Collaborator Author

@clalancette thanks for the review, your suggestions are applied.

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Jun 5, 2023
@clalancette clalancette merged commit 02f236b into rolling Jun 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the fujitatomoya/fastdds-uses-shm-transport branch June 5, 2023 18:22
mergify bot pushed a commit that referenced this pull request Jun 5, 2023
#3683)

* Fast-DDS uses SHM transport by default, so network traffic cannot be monitored with tcpdump.

Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit 02f236b)
mergify bot pushed a commit that referenced this pull request Jun 5, 2023
#3683)

* Fast-DDS uses SHM transport by default, so network traffic cannot be monitored with tcpdump.

Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit 02f236b)
mergify bot pushed a commit that referenced this pull request Jun 5, 2023
#3683)

* Fast-DDS uses SHM transport by default, so network traffic cannot be monitored with tcpdump.

Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit 02f236b)

# Conflicts:
#	source/Tutorials/Advanced/Security/Examine-Traffic.rst
clalancette pushed a commit that referenced this pull request Jun 5, 2023
#3683) (#3710)

* Fast-DDS uses SHM transport by default, so network traffic cannot be monitored with tcpdump.

Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit 02f236b)

Co-authored-by: Tomoya Fujita <[email protected]>
clalancette pushed a commit that referenced this pull request Jun 5, 2023
#3683) (#3711)

* Fast-DDS uses SHM transport by default, so network traffic cannot be monitored with tcpdump.

Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit 02f236b)

Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants