Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significantly clean up and expand the documentation about logging. #3025

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

clalancette
Copy link
Contributor

Explain a lot more about which APIs to use, which configuration options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette [email protected]

This PR incorporates parts of, and should supersede, #2028 , #2996 , and #2978 . @fujitatomoya @tfoote @tylerjw please take a look

Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <[email protected]>
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for organizing!

source/Concepts/About-Logging.rst Show resolved Hide resolved
@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Sep 23, 2022
@clalancette
Copy link
Contributor Author

Thanks for the review! I'm going to merge this and backport it.

@clalancette clalancette merged commit c23fff0 into rolling Sep 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the clalancette/cleanup-logging-docs branch September 23, 2022 12:48
mergify bot pushed a commit that referenced this pull request Sep 23, 2022
…3025)

Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit c23fff0)
mergify bot pushed a commit that referenced this pull request Sep 23, 2022
…3025)

Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit c23fff0)
mergify bot pushed a commit that referenced this pull request Sep 23, 2022
…3025)

Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit c23fff0)
clalancette added a commit that referenced this pull request Sep 23, 2022
…3025) (#3032)

Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit c23fff0)

Co-authored-by: Chris Lalancette <[email protected]>
clalancette added a commit that referenced this pull request Sep 23, 2022
…3025) (#3033)

Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit c23fff0)

Co-authored-by: Chris Lalancette <[email protected]>
clalancette added a commit that referenced this pull request Sep 23, 2022
…3025) (#3034)

Explain a lot more about which APIs to use, which configuration
options are available, and the design of the subsystem.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit c23fff0)

Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants