Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reference to the new source entry requirement for ros2-gbp repository creation. #2992

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

nuclearsandwich
Copy link
Member

@nuclearsandwich nuclearsandwich commented Aug 31, 2022

As discussed, we're adding a requirement to the release repository creation process to add a source stanza, ensuring that the packages in the new repository undergo rosdistro review before a release repository is created.
This is particularly important for naming convention review since that review could affect the name of the source, and by extension, release repository created.

Connects to ros2-gbp/ros2-gbp-github-org#106

…sitory creation.

As discussed, we're adding a requirement to the release repository
creation process to add a source stanza, ensuring that the packages in
the new repository undergo rosdistro review before a release repository
is created. This is particularly important for naming convention review
since that review could affect the name of the source, and by extension,
release repository created.
@nuclearsandwich nuclearsandwich self-assigned this Aug 31, 2022
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change to make it flow a bit better, then I'm happy with this.

source/How-To-Guides/Releasing/Release-Team-Repository.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for iterating!

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Sep 9, 2022
@clalancette clalancette merged commit ecdfd5f into rolling Sep 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the nuclearsandwich/ros2-gbp-process branch September 9, 2022 20:35
mergify bot pushed a commit that referenced this pull request Sep 9, 2022
…sitory creation. (#2992)

* Add a reference to the new source entry requirement for ros2-gbp repository creation.

As discussed, we're adding a requirement to the release repository
creation process to add a source stanza, ensuring that the packages in
the new repository undergo rosdistro review before a release repository
is created. This is particularly important for naming convention review
since that review could affect the name of the source, and by extension,
release repository created.

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit ecdfd5f)
mergify bot pushed a commit that referenced this pull request Sep 9, 2022
…sitory creation. (#2992)

* Add a reference to the new source entry requirement for ros2-gbp repository creation.

As discussed, we're adding a requirement to the release repository
creation process to add a source stanza, ensuring that the packages in
the new repository undergo rosdistro review before a release repository
is created. This is particularly important for naming convention review
since that review could affect the name of the source, and by extension,
release repository created.

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit ecdfd5f)
mergify bot pushed a commit that referenced this pull request Sep 9, 2022
…sitory creation. (#2992)

* Add a reference to the new source entry requirement for ros2-gbp repository creation.

As discussed, we're adding a requirement to the release repository
creation process to add a source stanza, ensuring that the packages in
the new repository undergo rosdistro review before a release repository
is created. This is particularly important for naming convention review
since that review could affect the name of the source, and by extension,
release repository created.

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit ecdfd5f)
clalancette pushed a commit that referenced this pull request Sep 9, 2022
…sitory creation. (#2992) (#3011)

* Add a reference to the new source entry requirement for ros2-gbp repository creation.

As discussed, we're adding a requirement to the release repository
creation process to add a source stanza, ensuring that the packages in
the new repository undergo rosdistro review before a release repository
is created. This is particularly important for naming convention review
since that review could affect the name of the source, and by extension,
release repository created.

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit ecdfd5f)

Co-authored-by: Steven! Ragnarök <[email protected]>
clalancette pushed a commit that referenced this pull request Sep 9, 2022
…sitory creation. (#2992) (#3012)

* Add a reference to the new source entry requirement for ros2-gbp repository creation.

As discussed, we're adding a requirement to the release repository
creation process to add a source stanza, ensuring that the packages in
the new repository undergo rosdistro review before a release repository
is created. This is particularly important for naming convention review
since that review could affect the name of the source, and by extension,
release repository created.

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit ecdfd5f)

Co-authored-by: Steven! Ragnarök <[email protected]>
clalancette pushed a commit that referenced this pull request Sep 9, 2022
…sitory creation. (#2992) (#3013)

* Add a reference to the new source entry requirement for ros2-gbp repository creation.

As discussed, we're adding a requirement to the release repository
creation process to add a source stanza, ensuring that the packages in
the new repository undergo rosdistro review before a release repository
is created. This is particularly important for naming convention review
since that review could affect the name of the source, and by extension,
release repository created.

Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit ecdfd5f)

Co-authored-by: Steven! Ragnarök <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants