Add tracing instrumentation using tracetools #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this instrumentation,
rmw_zenoh_cpp
is supported out-of-the-box by tools that process ROS 2 trace data, such as Eclipse Trace Compass.It's pretty straightforward except for a few things:
rmw_publisher_t *
for thermw_publish
tracepointPublisherData
.rmw_publish
tracepointrmw
. This means we don't need to instrument the underlying middleware itself, which we used to have to do.create_map_and_set_sequence_num()
to be able to extract the source timestamp.rmw
GID for thermw_subscription_init
tracepointI'm open to suggestions.