Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize PublsiherData only after all members are valid #289

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Initialize PublsiherData only after all members are valid #289

merged 2 commits into from
Oct 3, 2024
+64 −35

Conversation

Yadunund
Copy link
Member

@Yadunund Yadunund commented Oct 2, 2024 •
edited
Loading

Fix regression in rcl_lifecycle as per #286 (comment)

Note: we already do the same for NodeData

@ahcorde ahcorde merged commit 8ba1c91 into rolling Oct 3, 2024
8 checks passed
@ahcorde ahcorde deleted the yadu/fix_rcl_lifecycle_regression branch October 3, 2024 08:27
clalancette
clalancette reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After it is already merged, but this looks good to me. Thanks @Yadunund !

@clalancette clalancette mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette left review comments

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yadunund @clalancette @ahcorde