Continue shutting down other nodes if one fails

Signed-off-by: Yadunund <[email protected]>
ros2 · Sep 30, 2024 · 3c1e1eb · 3c1e1eb
1 parent 145a849
commit 3c1e1eb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/rmw_zenoh_cpp/src/detail/rmw_context_impl_s.cpp b/rmw_zenoh_cpp/src/detail/rmw_context_impl_s.cpp
@@ -158,7 +158,12 @@ rmw_ret_t rmw_context_impl_s::Data::shutdown()
   for (auto node_it = nodes_.begin(); node_it != nodes_.end(); ++node_it) {
     ret = node_it->second->shutdown();
     if (ret != RMW_RET_OK) {
-      return ret;
+      RMW_ZENOH_LOG_ERROR_NAMED(
+        "rmw_zenoh_cpp",
+        "Unable to shutdown node with id %zu. rmw_ret_t code: %zu",
+        node_it->second->id(),
+        ret
+      );
     }
   }
 

diff --git a/rmw_zenoh_cpp/src/rmw_zenoh.cpp b/rmw_zenoh_cpp/src/rmw_zenoh.cpp
@@ -22,7 +22,6 @@
 #include <mutex>
 #include <new>
 #include <optional>
-#include <random>
 #include <string>
 #include <utility>