Add pkcs11 support to get_security_files #66
Conversation
MiguelCompany
force-pushed
the
pkcs11-support
branch
2 times, most recently
from
7cf2a93
to
6e14022
Compare
|
Ping @clalancette or @mikaelarguedas ? Could you review? |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-02-16/29927/1 |
|
@MiguelCompany any update on this pr? Or should we wait REP-2015 to be approved first? |
|
@SubaruArai I don't know what the process is. I guess we should wait for REP-2015, but I am just an external contributor, and I suppose that someone in the ROS 2 team should answer that. Maybe @clalancette or @gbiggs can clarify? |
There was a problem hiding this comment.
This PR is stuck for a while, are we planning to merge this before feature freeze? @clalancette ?
I'm missing some tests in the test_security.cpp file. Do you mind to add them?
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
MiguelCompany
force-pushed
the
pkcs11-support
branch
from
6e14022
to
9d71742
Compare
|
@ahcorde I just rebased this. Will try to add tests in the |
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
|
@ahcorde I updated the tests in |
rmw_dds_common/src/security.cpp
Outdated
| std::vector<std::pair<std::string, security_file_processor>>; | ||
|
|
||
|
|
||
| // Key: the security attribute |
There was a problem hiding this comment.
| std::vector<std::pair<std::string, security_file_processor>>; | |
| // Key: the security attribute | |
| std::vector<std::pair<std::string, security_file_processor>>; | |
| // Key: the security attribute |
Signed-off-by: Miguel Company <[email protected]>
|
Here is CI for this:
|
|
A couple more pieces of CI, then I think this is good to go:
|
|
All of the warnings here were also in the nightlies, so going ahead and merging this one in. |
This implements ros2/design#332