Update graph API return codes. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eboasson
approved these changes
Sep 21, 2020
|
CI up to
|
|
@jacobperron I believe the problem with #241 was that CI was not properly run against actual tests (see here). Every modification here is checked against a corresponding test. |
|
CI up to
|
This patch affects: - rmw_get_node_names() - rmw_get_node_names_with_enclaves() - rmw_get_topic_names_and_types() - rmw_get_service_names_and_types() - rmw_get_publishers_info_by_topic() - rmw_get_subscriptions_info_by_topic() - rmw_get_subscriber_names_and_types_by_node() - rmw_get_publisher_names_and_types_by_node() - rmw_get_service_names_and_types_by_node() - rmw_get_client_names_and_types_by_node() - rmw_count_publishers() - rmw_count_subscribers() Signed-off-by: Michel Hidalgo <[email protected]>
hidmic
force-pushed
the
hidmic/update-graph-api-ret
branch
from
a0a74a5
to
0757fd2
Compare
|
Argh, I had to rebase after #245. CI up to
|
|
Alright, going in! Thanks for all the good reviews! |
ahcorde
pushed a commit
that referenced
this pull request
Oct 9, 2020
This patch affects: - rmw_get_node_names() - rmw_get_node_names_with_enclaves() - rmw_get_topic_names_and_types() - rmw_get_service_names_and_types() - rmw_get_publishers_info_by_topic() - rmw_get_subscriptions_info_by_topic() - rmw_get_subscriber_names_and_types_by_node() - rmw_get_publisher_names_and_types_by_node() - rmw_get_service_names_and_types_by_node() - rmw_get_client_names_and_types_by_node() - rmw_count_publishers() - rmw_count_subscribers() Signed-off-by: Michel Hidalgo <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Oct 15, 2020
This patch affects: - rmw_get_node_names() - rmw_get_node_names_with_enclaves() - rmw_get_topic_names_and_types() - rmw_get_service_names_and_types() - rmw_get_publishers_info_by_topic() - rmw_get_subscriptions_info_by_topic() - rmw_get_subscriber_names_and_types_by_node() - rmw_get_publisher_names_and_types_by_node() - rmw_get_service_names_and_types_by_node() - rmw_get_client_names_and_types_by_node() - rmw_count_publishers() - rmw_count_subscribers() Signed-off-by: Michel Hidalgo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to ros2/rmw#272. This patch affects:
rmw_get_node_names()rmw_get_node_names_with_enclaves()rmw_get_topic_names_and_types()rmw_get_service_names_and_types()rmw_get_publishers_info_by_topic()rmw_get_subscriptions_info_by_topic()rmw_get_subscriber_names_and_types_by_node()rmw_get_publisher_names_and_types_by_node()rmw_get_service_names_and_types_by_node()rmw_get_client_names_and_types_by_node()rmw_count_publishers()rmw_count_subscribers()