Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription types #1281

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Subscription types #1281

merged 6 commits into from
Aug 7, 2024

Conversation

InvincibleRMC
Copy link
Contributor

@InvincibleRMC InvincibleRMC commented May 8, 2024

Adds types to Subscriptions. Also fixes previously incorrect callback type. Same as #1239. It needs ros2/rosidl_python#205 or all of the generics are treated as Any.

Signed-off-by: Michael Carlstrom <[email protected]>
InvincibleRMC and others added 4 commits May 8, 2024 13:30
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
@sloretz sloretz self-assigned this May 16, 2024
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@sloretz
Copy link
Contributor

sloretz commented Aug 7, 2024

Pulls: #1281
Gist: https://gist.githubusercontent.com/sloretz/c612f271f220c98bb3fedc45ae4f3f27/raw/4051eb1463760a8dc2c44b1bb2c3fb5e7bc769fd/ros2.repos
BUILD args: --packages-up-to rclpy
TEST args: --packages-select rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14377

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz sloretz merged commit 35d494c into ros2:rolling Aug 7, 2024
3 checks passed
@InvincibleRMC InvincibleRMC deleted the subscription-types branch September 13, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants