fix events-executor warm-up bug and add unit-tests (backport #2591) #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* add unit-test to verify that spin-all doesn't need warm-up Signed-off-by: Alberto Soragna <[email protected]> * improve comment and add callback group test Signed-off-by: Alberto Soragna <[email protected]> * move executor tests to a new file Signed-off-by: Alberto Soragna <[email protected]> * do not require warm up iteration with events executor spin_some Signed-off-by: Alberto Soragna <[email protected]> * add spin_some tests and cleanup Signed-off-by: Alberto Soragna <[email protected]> * add missing include directives Signed-off-by: Alberto Soragna <[email protected]> --------- Signed-off-by: Alberto Soragna <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit f7056c0) # Conflicts: # rclcpp/src/rclcpp/experimental/executors/events_executor/events_executor.cpp
|
Cherry-pick of f7056c0 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Replaced by #2628 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote a test to verify the behavior of
spin_all, that should collect work multiple times (if given enough duration) and this should allow to also get work from entities created after the node / cb group was added to the executor.See #2589 for details
This is an automatic backport of pull request #2591 done by Mergify.