Revert "Revert "Add support for spin_until_timeout (#1821)"" #1957

wjwwood · 2022-06-24T18:21:53Z

Reverts #1956

An un-revert of #1874, see #1874 (comment).

…_until_future_complete with spin_until_complete. (#1821) (#1874)" (#1956)" This reverts commit f43a919.

fujitatomoya · 2022-06-24T20:42:26Z

This must go with the following PRs together.

fujitatomoya

lgtm

rclcpp/include/rclcpp/executor.hpp

fujitatomoya · 2022-07-19T08:39:29Z

@SteveMacenski thanks for the review for all dependent packages. I will run CI on these changes.

fujitatomoya · 2022-07-19T08:51:19Z

CI: (https://gist.githubusercontent.com/fujitatomoya/0a60de77545302dbdd7c61fbfadc5e5d/raw/947cafa17c53eb6d9f793018fc256be13a1f3075/ros2.repos)

Linux
Linux-aarch64
Windows

christophebedard · 2022-11-22T23:54:25Z

@fujitatomoya is this (and related PRs) still ready to be merged?

fujitatomoya · 2022-11-30T18:36:54Z

@christophebedard there are conflicts, we need to rebase some of them. we have complete list on #1957 (comment). anyway i will check those again.

christophebedard · 2022-11-30T18:43:38Z

@christophebedard there are conflicts, we need to rebase some of them. we have complete list on #1957 (comment). anyway i will check those again.

Alright. Please note that the ros2_tracing PR is now at ros2/ros2_tracing#2

Signed-off-by: Tomoya Fujita <[email protected]>

fujitatomoya · 2023-01-23T17:56:29Z

@hliberacki i fixed conflict on this PR synced with rolling, could you do the review just in case?

Signed-off-by: Tomoya Fujita <[email protected]>

fujitatomoya · 2023-01-23T18:31:40Z

okay we have many deprecated warnings related to this PR.

colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Debug --packages-select rclcpp rclcpp_action

root@tomoyafujita:~/ros2_ws/colcon_ws# colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Debug --packages-select rclcpp rclcpp_action
Starting >>> rclcpp  
[Processing: rclcpp]                             
[Processing: rclcpp]                                     
[Processing: rclcpp]                                       
--- stderr: rclcpp                                          
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp: In instantiation of ‘void TestAddCallbackGroupsToExecutor_subscriber_triggered_to_receive_message_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = rclcpp::executors::MultiThreadedExecutor]’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:285:1:   required from here
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:300:63: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<bool>; TimeRepT = long int; TimeT = std::ratio<1>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  300 |       return_code = cb_grp_executor.spin_until_future_complete(received_message_future, 10s);
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:336:44: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<void>; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  336 |   timer_executor.spin_until_future_complete(future);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp: In instantiation of ‘void TestAddCallbackGroupsToExecutor_subscriber_triggered_to_receive_message_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = rclcpp::executors::StaticSingleThreadedExecutor]’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:285:1:   required from here
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:300:63: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<bool>; TimeRepT = long int; TimeT = std::ratio<1>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  300 |       return_code = cb_grp_executor.spin_until_future_complete(received_message_future, 10s);
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:336:44: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<void>; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  336 |   timer_executor.spin_until_future_complete(future);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp: In instantiation of ‘void TestAddCallbackGroupsToExecutor_subscriber_triggered_to_receive_message_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = rclcpp::executors::SingleThreadedExecutor]’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:285:1:   required from here
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:300:63: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<bool>; TimeRepT = long int; TimeT = std::ratio<1>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  300 |       return_code = cb_grp_executor.spin_until_future_complete(received_message_future, 10s);
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:336:44: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<void>; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  336 |   timer_executor.spin_until_future_complete(future);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp: In instantiation of ‘void TestAddCallbackGroupsToExecutor_subscriber_triggered_to_receive_message_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = rclcpp::executors::MultiThreadedExecutor]’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:285:1:   required from here
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:300:63: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<bool>; TimeRepT = long int; TimeT = std::ratio<1>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  300 |       return_code = cb_grp_executor.spin_until_future_complete(received_message_future, 10s);
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:336:44: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<void>; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  336 |   timer_executor.spin_until_future_complete(future);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp: In instantiation of ‘void TestAddCallbackGroupsToExecutor_subscriber_triggered_to_receive_message_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = rclcpp::executors::StaticSingleThreadedExecutor]’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:285:1:   required from here
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:300:63: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<bool>; TimeRepT = long int; TimeT = std::ratio<1>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  300 |       return_code = cb_grp_executor.spin_until_future_complete(received_message_future, 10s);
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:336:44: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<void>; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  336 |   timer_executor.spin_until_future_complete(future);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp: In instantiation of ‘void TestAddCallbackGroupsToExecutor_subscriber_triggered_to_receive_message_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = rclcpp::executors::SingleThreadedExecutor]’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:285:1:   required from here
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:300:63: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<bool>; TimeRepT = long int; TimeT = std::ratio<1>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  300 |       return_code = cb_grp_executor.spin_until_future_complete(received_message_future, 10s);
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:336:44: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<void>; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  336 |   timer_executor.spin_until_future_complete(future);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp: In instantiation of ‘void TestAddCallbackGroupsToExecutor_subscriber_triggered_to_receive_message_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = rclcpp::executors::MultiThreadedExecutor]’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:285:1:   required from here
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:300:63: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<bool>; TimeRepT = long int; TimeT = std::ratio<1>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  300 |       return_code = cb_grp_executor.spin_until_future_complete(received_message_future, 10s);
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:336:44: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<void>; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  336 |   timer_executor.spin_until_future_complete(future);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp: In instantiation of ‘void TestAddCallbackGroupsToExecutor_subscriber_triggered_to_receive_message_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = rclcpp::executors::StaticSingleThreadedExecutor]’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:285:1:   required from here
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:300:63: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<bool>; TimeRepT = long int; TimeT = std::ratio<1>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  300 |       return_code = cb_grp_executor.spin_until_future_complete(received_message_future, 10s);
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:336:44: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<void>; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  336 |   timer_executor.spin_until_future_complete(future);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp: In instantiation of ‘void TestAddCallbackGroupsToExecutor_subscriber_triggered_to_receive_message_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = rclcpp::executors::MultiThreadedExecutor]’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:285:1:   required from here
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:300:63: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<bool>; TimeRepT = long int; TimeT = std::ratio<1>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  300 |       return_code = cb_grp_executor.spin_until_future_complete(received_message_future, 10s);
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:336:44: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<void>; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  336 |   timer_executor.spin_until_future_complete(future);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp: In instantiation of ‘void TestAddCallbackGroupsToExecutor_subscriber_triggered_to_receive_message_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = rclcpp::executors::SingleThreadedExecutor]’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:285:1:   required from here
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:300:63: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<bool>; TimeRepT = long int; TimeT = std::ratio<1>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  300 |       return_code = cb_grp_executor.spin_until_future_complete(received_message_future, 10s);
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:336:44: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<void>; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  336 |   timer_executor.spin_until_future_complete(future);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp: In instantiation of ‘void TestAddCallbackGroupsToExecutor_subscriber_triggered_to_receive_message_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = rclcpp::executors::StaticSingleThreadedExecutor]’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:285:1:   required from here
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:300:63: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<bool>; TimeRepT = long int; TimeT = std::ratio<1>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  300 |       return_code = cb_grp_executor.spin_until_future_complete(received_message_future, 10s);
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:336:44: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<void>; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  336 |   timer_executor.spin_until_future_complete(future);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp: In instantiation of ‘void TestAddCallbackGroupsToExecutor_subscriber_triggered_to_receive_message_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = rclcpp::executors::SingleThreadedExecutor]’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:285:1:   required from here
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:300:63: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<bool>; TimeRepT = long int; TimeT = std::ratio<1>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  300 |       return_code = cb_grp_executor.spin_until_future_complete(received_message_future, 10s);
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:336:44: warning: ‘rclcpp::FutureReturnCode rclcpp::Executor::spin_until_future_complete(const FutureT&, std::chrono::duration<_Rep, _Period>) [with FutureT = std::future<void>; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(const ConditionT & condition, DurationT timeout) instead [-Wdeprecated-declarations]
  336 |   timer_executor.spin_until_future_complete(future);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors/multi_threaded_executor.hpp:25,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:21,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp:29:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executor.hpp:381:3: note: declared here
  381 |   spin_until_future_complete(
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp: In member function ‘virtual void TestParameterClient_async_parameter_load_parameters_complicated_regex_Test::TestBody()’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:985:56: warning: ‘rclcpp::FutureReturnCode rclcpp::spin_until_future_complete(std::shared_ptr<_Tp>, const FutureT&, std::chrono::duration<_Rep2, _Period2>) [with NodeT = rclcpp::Node; FutureT = std::shared_future<std::vector<rcl_interfaces::msg::SetParametersResult_<std::allocator<void> > > >; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(std::shared_ptr<NodeT>, const ConditionT &, DurationT) instead [-Wdeprecated-declarations]
  985 |   auto result_code = rclcpp::spin_until_future_complete(
      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
  986 |     load_node, load_future, std::chrono::milliseconds(100));
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/rclcpp.hpp:155,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:25:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:194:1: note: declared here
  194 | spin_until_future_complete(
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:991:37: warning: ‘rclcpp::FutureReturnCode rclcpp::spin_until_future_complete(std::shared_ptr<_Tp>, const FutureT&, std::chrono::duration<_Rep2, _Period2>) [with NodeT = rclcpp::Node; FutureT = std::shared_future<rcl_interfaces::msg::ListParametersResult_<std::allocator<void> > >; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(std::shared_ptr<NodeT>, const ConditionT &, DurationT) instead [-Wdeprecated-declarations]
  991 |   rclcpp::spin_until_future_complete(
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
  992 |     load_node, list_parameters, std::chrono::milliseconds(100));
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/rclcpp.hpp:155,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:25:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:194:1: note: declared here
  194 | spin_until_future_complete(
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp: In member function ‘virtual void TestParameterClient_async_parameter_load_parameters_from_map_Test::TestBody()’:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:1063:56: warning: ‘rclcpp::FutureReturnCode rclcpp::spin_until_future_complete(std::shared_ptr<_Tp>, const FutureT&, std::chrono::duration<_Rep2, _Period2>) [with NodeT = rclcpp::Node; FutureT = std::shared_future<std::vector<rcl_interfaces::msg::SetParametersResult_<std::allocator<void> > > >; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(std::shared_ptr<NodeT>, const ConditionT &, DurationT) instead [-Wdeprecated-declarations]
 1063 |   auto result_code = rclcpp::spin_until_future_complete(
      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
 1064 |     load_node, load_future, std::chrono::milliseconds(100));
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/rclcpp.hpp:155,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:25:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:194:1: note: declared here
  194 | spin_until_future_complete(
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:1069:37: warning: ‘rclcpp::FutureReturnCode rclcpp::spin_until_future_complete(std::shared_ptr<_Tp>, const FutureT&, std::chrono::duration<_Rep2, _Period2>) [with NodeT = rclcpp::Node; FutureT = std::shared_future<rcl_interfaces::msg::ListParametersResult_<std::allocator<void> > >; TimeRepT = long int; TimeT = std::ratio<1, 1000>]’ is deprecated: use spin_until_complete(std::shared_ptr<NodeT>, const ConditionT &, DurationT) instead [-Wdeprecated-declarations]
 1069 |   rclcpp::spin_until_future_complete(
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
 1070 |     load_node, list_parameters, std::chrono::milliseconds(100));
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/rclcpp.hpp:155,
                 from /root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:25:
/root/ros2_ws/colcon_ws/src/ros2/rclcpp/rclcpp/include/rclcpp/executors.hpp:194:1: note: declared here
  194 | spin_until_future_complete(
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
---
Finished <<< rclcpp [1min 39s]
Starting >>> rclcpp_action
Finished <<< rclcpp_action [16.2s]                            

Summary: 2 packages finished [1min 56s]
  1 package had stderr output: rclcpp

Signed-off-by: Tomoya Fujita <[email protected]>

fujitatomoya · 2023-01-23T18:48:39Z

This should be good to go, local test with colcon test --event-handlers console_direct+ --packages-select rclcpp rclcpp_action succeeds w/o error.

fujitatomoya · 2023-01-23T18:58:55Z

CC: @christophebedard

christophebedard · 2024-01-25T19:24:56Z

Could we pick this back up?

SteveMacenski · 2024-01-25T19:30:03Z

Very much please 😄 I want this in Jazzy

christophebedard · 2024-04-02T21:15:29Z

I've opened #2475 to replace this PR.

clalancette · 2024-04-04T01:56:53Z

I'm going to close this one, as it is replaced by #2475

Revert "Revert "Introduce executors new spin_for method, replace spin…

0f90756

…_until_future_complete with spin_until_complete. (#1821) (#1874)" (#1956)" This reverts commit f43a919.

wjwwood mentioned this pull request Jun 24, 2022

Add support for spin_until_timeout (#1821) #1874

Merged

audrow changed the base branch from master to rolling June 28, 2022 14:20

clalancette self-requested a review July 14, 2022 17:13

clalancette assigned wjwwood Jul 14, 2022

fujitatomoya approved these changes Jul 19, 2022

View reviewed changes

rclcpp/include/rclcpp/executor.hpp Outdated Show resolved Hide resolved

fujitatomoya self-assigned this Dec 14, 2022

fujitatomoya mentioned this pull request Jan 23, 2023

spin until timeout #1821

Open

fujitatomoya requested review from ivanpauno and hidmic as code owners January 23, 2023 17:44

Merge branch 'rolling' into revert-1956-revert-1874-hliberacki/timeout

cde7a67

Signed-off-by: Tomoya Fujita <[email protected]>

fujitatomoya force-pushed the revert-1956-revert-1874-hliberacki/timeout branch from 447ba81 to cde7a67 Compare January 23, 2023 17:49

address lint error.

7637e77

Signed-off-by: Tomoya Fujita <[email protected]>

replace spin_until_future_complete to spin_until_complete.

4dea2e1

Signed-off-by: Tomoya Fujita <[email protected]>

audrow mentioned this pull request Feb 13, 2023

Revert "Revert "adding API change for spin_until_complete"" ros2/ros2_documentation#3334

Closed

Crola1702 mentioned this pull request Oct 26, 2023

Deprecated spin_until_future_complete ros-visualization/interactive_markers#90

Merged

christophebedard mentioned this pull request Apr 2, 2024

Add support for spin_until_complete (take 2) #2475

Open

clalancette closed this Apr 4, 2024

clalancette deleted the revert-1956-revert-1874-hliberacki/timeout branch April 4, 2024 01:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Revert "Add support for spin_until_timeout (#1821)"" #1957

Revert "Revert "Add support for spin_until_timeout (#1821)"" #1957

wjwwood commented Jun 24, 2022

fujitatomoya commented Jun 24, 2022 •

edited by christophebedard

Loading

fujitatomoya left a comment

fujitatomoya commented Jul 19, 2022

fujitatomoya commented Jul 19, 2022

christophebedard commented Nov 22, 2022

fujitatomoya commented Nov 30, 2022

christophebedard commented Nov 30, 2022

fujitatomoya commented Jan 23, 2023

fujitatomoya commented Jan 23, 2023

fujitatomoya commented Jan 23, 2023

fujitatomoya commented Jan 23, 2023

christophebedard commented Jan 25, 2024

SteveMacenski commented Jan 25, 2024

christophebedard commented Apr 2, 2024

clalancette commented Apr 4, 2024

Revert "Revert "Add support for spin_until_timeout (#1821)"" #1957

Revert "Revert "Add support for spin_until_timeout (#1821)"" #1957

Conversation

wjwwood commented Jun 24, 2022

fujitatomoya commented Jun 24, 2022 • edited by christophebedard Loading

fujitatomoya left a comment

Choose a reason for hiding this comment

fujitatomoya commented Jul 19, 2022

fujitatomoya commented Jul 19, 2022

christophebedard commented Nov 22, 2022

fujitatomoya commented Nov 30, 2022

christophebedard commented Nov 30, 2022

fujitatomoya commented Jan 23, 2023

fujitatomoya commented Jan 23, 2023

fujitatomoya commented Jan 23, 2023

fujitatomoya commented Jan 23, 2023

christophebedard commented Jan 25, 2024

SteveMacenski commented Jan 25, 2024

christophebedard commented Apr 2, 2024

clalancette commented Apr 4, 2024

fujitatomoya commented Jun 24, 2022 •

edited by christophebedard

Loading