Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a context pointer to subscriptions (backport #107) #121

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 13, 2021

This is an automatic backport of pull request #107 done by Mergify.
Cherry-pick of 5b11c5a has failed:

On branch mergify/bp/master/pr-107
Your branch is up to date with 'origin/master'.

You are currently cherry-picking commit 5b11c5a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   NOTICE
	modified:   rclc/include/rclc/executor.h
	modified:   rclc/include/rclc/executor_handle.h
	modified:   rclc/src/rclc/executor.c
	modified:   rclc/src/rclc/executor_handle.c
	modified:   rclc/test/rclc/test_executor.cpp
	new file:   rclc_examples/src/example_sub_context.c

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclc_examples/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

(cherry picked from commit 5b11c5a)

# Conflicts:
#	rclc_examples/CMakeLists.txt
@codecov-commenter
Copy link

Codecov Report

Merging #121 (5b11c5a) into master (8697d7d) will decrease coverage by 0.88%.
The diff coverage is n/a.

❗ Current head 5b11c5a differs from pull request most recent head 4ee3509. Consider uploading reports for the commit 4ee3509 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   29.56%   28.68%   -0.89%     
==========================================
  Files         243       28     -215     
  Lines       24444     3246   -21198     
  Branches    12312     1679   -10633     
==========================================
- Hits         7227      931    -6296     
+ Misses       6885      914    -5971     
+ Partials    10332     1401    -8931     
Impacted Files Coverage Δ
...aw/rclc/rclc_examples/src/example_lifecycle_node.c
...c/71b65q9ngn7/rclc/rclc/src/rclc/executor_handle.c
ros_ws/src/71b65q9ngn7/rclc/rclc/src/rclc/init.c
...rclc_lifecycle/src/rclc_lifecycle/rclc_lifecycle.c
ros_ws/src/71b65q9ngn7/rclc/rclc/src/rclc/timer.c
...rclc_lifecycle/src/rclc_lifecycle/rclc_lifecycle.c
...5apnlmh7/rclc/rclc_examples/src/example_executor.c
.../src/709f64qbexs/rclc/rclc/test/rclc/test_node.cpp
ros_ws/src/vp5apnlmh7/rclc/rclc/src/rclc/timer.c
...os_ws/src/7aqjevewu6/rclc/rclc/src/rclc/executor.c
... and 261 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0263722...4ee3509. Read the comment docs.

Signed-off-by: Jan Staschulat <[email protected]>
@JanStaschulat JanStaschulat self-requested a review July 15, 2021 15:58
@JanStaschulat JanStaschulat merged commit 383fb71 into master Jul 15, 2021
@JanStaschulat JanStaschulat deleted the mergify/bp/master/pr-107 branch July 15, 2021 15:59
@JanStaschulat
Copy link
Contributor

solves #50 forRolling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants