Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rcl_logging_allocator_initialize() support. #1049

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

rcl_logging_allocator_initialize() support. #1049

wants to merge 1 commit into from

Conversation

fujitatomoya
Copy link
Collaborator

address #1037

@fujitatomoya
Copy link
Collaborator Author

@iuhilnehc-ynos can you review this?

fujitatomoya
fujitatomoya commented Mar 24, 2023
View reviewed changes
rcl/src/rcl/init.c
@@ -67,6 +67,7 @@ rcl_init(
rcl_allocator_t allocator = options->impl->allocator;
RCL_CHECK_ALLOCATOR(&allocator, return RCL_RET_INVALID_ARGUMENT);
RCL_CHECK_ARGUMENT_FOR_NULL(context, RCL_RET_INVALID_ARGUMENT);
RCUTILS_LOGGING_AUTOINIT_WITH_ALLOCATOR(allocator);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the fix to take user defined allocator in account.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding this is enough in rcl, and then fix the rcutils by updating the default log level with an environment variable if exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuhilnehc-ynos iuhilnehc-ynos iuhilnehc-ynos left review comments

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fujitatomoya @iuhilnehc-ynos