-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Add manual call policy according with FIFO and timestamp. #107
base: rolling
Are you sure you want to change the base?
Conversation
@clalancette @gbiggs friendly ping for updates. |
@@ -0,0 +1,131 @@ | |||
/********************************************************************* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use hpp
extension instead of h
.
#include "message_filters/connection.h" | ||
#include "message_filters/message_traits.h" | ||
#include "message_filters/null_types.h" | ||
#include "message_filters/signal9.h" | ||
#include "message_filters/synchronizer.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use hpp
includes.
* It is up to the programmer to call #call when it is time to process the information. This policy class | ||
* is meant to be used in networks where information is processed periodically. | ||
*/ | ||
template<typename M0, typename M1, typename M2 = NullType, typename M3 = NullType, typename M4 = NullType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use variadoc templates like in this PR https://github.com/ros2/message_filters/pull/93/files
In the others files as well
/********************************************************************* | ||
* Software License Agreement (BSD License) | ||
* | ||
* Copyright (c) 2009, Willow Garage, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this correct? you can use 2024 and Open Robotics
header.stamp = stamp; | ||
} | ||
}; | ||
typedef std::shared_ptr<Msg> MsgPtr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include <memory>
ASSERT_TRUE(helper.e1_ == evt_2); | ||
ASSERT_TRUE(helper.e2_ == evt_2_hl); | ||
ASSERT_TRUE(helper.e3_ == evt_3); | ||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
Continue the work from PR #38 . Originally created by @jacobperron
The existing change requests in #38 are resolved.
UT passed, Please review @clalancette