Merge apex_launchtest_ros functionality into launch_testing_ros #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI (full run):
|
29 tasks
hidmic
force-pushed
the
hidmic/import_launch_testing
branch
from
fc8d1a2
to
eb78d55
Compare
This was referenced Apr 16, 2019
|
I'll rebase after fixing this on Windows (which I suspect wasn't supported to begin with). |
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
hidmic
force-pushed
the
hidmic/import_launch_testing
branch
from
eb78d55
to
87350dc
Compare
|
Alright, all tests are passing but for a few unrelated, known failures! Running a linux packaging job just in case. |
ivanpauno
reviewed
Apr 25, 2019
| @@ -0,0 +1,63 @@ | |||
| # Copyright 2018 Open Source Robotics Foundation, Inc. | |||
There was a problem hiding this comment.
Is it not 2019?
Or this came from another file?
There was a problem hiding this comment.
It did came from somewhere else but 2019 is still correct.
|
Also, one of the tests is failing to me locally. So, check having green CI again. |
Signed-off-by: Michel Hidalgo <[email protected]>
jacobperron
approved these changes
Apr 29, 2019
wjwwood
approved these changes
Apr 30, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request merges functionality from
apex_launchtest_rospackage intolaunch_testing_ros. Some renaming and style corrections were applied as well.Connected to ros2/launch#208.