add format overriding by environment variables #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Bestmann <[email protected]>
SammyRamone
requested review from
adityapande-1995,
methylDragon and
wjwwood
as code owners
|
friendly ping @adityapande-1995 @methylDragon @wjwwood |
methylDragon
requested changes
Oct 3, 2023
Signed-off-by: Marc Bestmann <[email protected]>
|
Sorry for the long wait. This was fairly low-priority for me and I only now had time to work on it again. |
|
I also added a draft PR for documenting this PR ros2/ros2_documentation#4061 |
|
friendly ping @methylDragon |
adityapande-1995
approved these changes
Jan 26, 2024
|
@SammyRamone thanks for the patience ! The team had a discussion about this, and while we do think there should be a holistic way to configure all of this logging, this is a good feature. I'll run full CI on this. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for ros2/launch_ros#368
Originally, I planned on reusing the
RCUTILS_CONSOLE_OUTPUT_FORMATenvironment variable for this. Hoewever, this is not possible since launch and rcutils rely on two different logging implementations which have different names for the same things. For example one supports {line_number} and the other {lineno}. Instead I added two environment variablesOVERRIDE_LAUNCH_SCREEN_FORMATandOVERRIDE_LAUNCH_LOG_FORMATsince screen and log formatting is handled differently in the code.I also framed the variables as override similar to #713
Any feedback is welcome.