Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added README.md for composition #598

Merged
merged 10 commits into from
Feb 7, 2023

Conversation

cardboardcode
Copy link
Contributor

Purpose of Pull Request

This pull request adds a README.md to composition as part of efforts to address the issue highlighted in #531.

composition/README.md Outdated Show resolved Hide resolved
Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. I've added a few small fixes.

composition/README.md Outdated Show resolved Hide resolved
composition/README.md Outdated Show resolved Hide resolved
composition/README.md Outdated Show resolved Hide resolved
Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @mjeronimo, want to do one last pass?

@mjeronimo
Copy link
Contributor

Yes, I'll take a look...

Copy link
Contributor

@mjeronimo mjeronimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one minor suggestion.

composition/README.md Outdated Show resolved Hide resolved
@mjeronimo mjeronimo merged commit c17d5fa into ros2:rolling Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants