Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added README.md for dummy_sensors #573

Merged
merged 4 commits into from
Jan 23, 2023

Conversation

cardboardcode
Copy link
Contributor

Purpose of Pull Request

This pull request adds a README.md to dummy_sensors as part of efforts to address the issue highlighted in #531.

@audrow audrow self-assigned this Jul 26, 2022
@audrow audrow self-requested a review July 26, 2022 17:01
@cardboardcode cardboardcode marked this pull request as draft August 13, 2022 16:19
…or better cross-platform-compatibility.

Signed-off-by: Bey Hao Yun <[email protected]>
@cardboardcode cardboardcode marked this pull request as ready for review January 23, 2023 15:57
dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, a couple more changes that I missed last time. With that done, this looks good to me. Thanks for iterating.

dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the iteration here. Despite the fact that we haven't merged in the related dummy_robot_bringup PR yet, I'm going to merge this in as this is a strict improvement over what was there.

@clalancette clalancette merged commit 404ccd7 into ros2:rolling Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants