fix Timers not being invoked when using ActionClients or ActionServer within the same node #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s within the same node
The old comment only mentioned times, but this applies to the other waitables as well.
|
@hofmannmarkus0 Thanks for the PR :) This was some detail overseen when merging #124. @Chootin This issue may be in your branches as well, you may want to cherry-pick before you get into the same issue :) |
stefan991
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently when running a node that creates an ActionClient or ActionServer, creating a Timer in the same node will just not execute the timer callback at all as it tries to execute the timer at index 0, but ActionClient and ActionServer add their Timers to the WaitSet first.