cache tf_prefix #201
Open
cache tf_prefix #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
reviewed
Oct 12, 2022
| @@ -87,7 +87,8 @@ class JointStateListener { | |||
| MimicMap mimic_; | |||
| bool use_tf_static_; | |||
| bool ignore_timestamp_; | |||
|
|
|||
| std::string tf_prefix_; | |||
| bool tf_prefix_cached_; | |||
There was a problem hiding this comment.
Adding these members changes the size of the class, and that breaks ABI. This will have to be stored somewhere else so we can release it into Noetic.
One solution I've seen is to create a static global map in the .cpp file where the key is the this pointer, and the value is the things we want to store per class instance.
There was a problem hiding this comment.
Thank you for your quick review!
I've put a minimal thread-safe map and stored (this, tf_prefix) in the callback. The entry is deleted in the destructor.
|
we're hitting this as well, would be great if it could get merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On every joint_state callback, the node searches
tf_prefixparameter, and it loads an unignorable impact on roscore processes.This patch caches the result of the first search of tf_prefix. A downside is that we cannot update tf_prefix dynamically anymore (anyone does?).
ref. #200