-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ros2plugin #165
base: rolling
Are you sure you want to change the base?
Add ros2plugin #165
Conversation
Signed-off-by: artivis <[email protected]>
@ros-pull-request-builder retest this please |
@artivis I'll do an initial review of this PR, hopefully before the end of this week. Will you be able to assume maintainership of the ros2plugin package once it's merged? I'll take care of making sure you have the access you need and set up the necessary metadata to route notifications appropriately. |
@nuclearsandwich yes I'll assume maintainership of the |
@nuclearsandwich Hey, any update for this PR? |
Signed-off-by: artivis <[email protected]>
Good catch, thanks @Arnatious! |
@nuclearsandwich gentle ping on this. |
Any update on this ? Or is there already a way of listing installed plugins ? |
@nuclearsandwich |
Hello, @nuclearsandwich @artivis @Arnatious @audrow What is missing from this PR before it can be merged? Best, |
any news on this ? |
I was hoping this feature would be in ROS 2, is there any plans to merge this in or get it looked at again? |
@Arnatious @nuclearsandwich is there anything else that needs to be addressed for this PR? It'd be a great functionality for the |
Is there any update on this feature? |
Add the
plugin
command together with thelist
verb toros2
CLI.At the moment it produces the following results:
while passing the flag
--packages
only list packages that export plugins and the relative path to the XML file(s ?),I'd be more than open to discuss actual output and/or output layout.
Note this does not exactly mimic ROS 1 in terms of prints layout nor in terms of use (yet),
e.g. ROS 1 -->
rospack plugins --attrib=plugin <base_package_name>
.Fix ros2/ros2cli#328
Replace ros2/ros2cli#340
Signed-off-by: artivis [email protected]