Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ros2plugin #165

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

Add ros2plugin #165

wants to merge 2 commits into from

Conversation

artivis
Copy link
Contributor

@artivis artivis commented Oct 4, 2019

Add the plugin command together with the list verb to ros2 CLI.

At the moment it produces the following results:

$ ros2 plugin list
demo_plugin_component:
	Plugin(name='ros2_playground::MessageWriterDerived', type='ros2_playground::MessageWriterDerived', base='ros2_playground::MessageWriter')
rviz_default_plugins:
	Plugin(name='rviz_default_plugins/Camera', type='rviz_default_plugins::displays::CameraDisplay', base='rviz_common::Display')
	Plugin(name='rviz_default_plugins/Grid', type='rviz_default_plugins::displays::GridDisplay', base='rviz_common::Display')
	...

while passing the flag --packages only list packages that export plugins and the relative path to the XML file(s ?),

$ ros2 plugin list --packages
demo_plugin_component:
	share/demo_plugin_component/plugins_description.xml
rviz_default_plugins:
	share/rviz_default_plugins/plugins_description.xml

I'd be more than open to discuss actual output and/or output layout.

Note this does not exactly mimic ROS 1 in terms of prints layout nor in terms of use (yet),
e.g. ROS 1 --> rospack plugins --attrib=plugin <base_package_name>.

Fix ros2/ros2cli#328
Replace ros2/ros2cli#340

Signed-off-by: artivis [email protected]

Signed-off-by: artivis <[email protected]>
@nuclearsandwich
Copy link
Member

@ros-pull-request-builder retest this please

@nuclearsandwich nuclearsandwich self-requested a review October 14, 2019 21:37
@nuclearsandwich
Copy link
Member

@artivis I'll do an initial review of this PR, hopefully before the end of this week. Will you be able to assume maintainership of the ros2plugin package once it's merged? I'll take care of making sure you have the access you need and set up the necessary metadata to route notifications appropriately.

@artivis
Copy link
Contributor Author

artivis commented Oct 15, 2019

@nuclearsandwich yes I'll assume maintainership of the ros2plugin once merged 👍

@artivis
Copy link
Contributor Author

artivis commented Dec 18, 2019

@nuclearsandwich Hey, any update for this PR?

Signed-off-by: artivis <[email protected]>
@artivis
Copy link
Contributor Author

artivis commented Jan 13, 2020

Good catch, thanks @Arnatious!

@nuclearsandwich nuclearsandwich added the ros2 Issues and PRs relating to ROS 2 label Apr 21, 2020
@kyrofa
Copy link

kyrofa commented Jun 5, 2020

@nuclearsandwich gentle ping on this.

@doisyg
Copy link

doisyg commented Jan 19, 2022

Any update on this ? Or is there already a way of listing installed plugins ?

@audrow audrow changed the base branch from ros2 to rolling June 28, 2022 14:17
@HansRobo
Copy link

@nuclearsandwich
I'm looking forward to this feature, any plans to merge it in ros2?

@ljaniec
Copy link

ljaniec commented Dec 6, 2022

Hello, @nuclearsandwich @artivis @Arnatious @audrow

What is missing from this PR before it can be merged?

Best,
Łukasz

@mnumanuyar
Copy link

any news on this ?

@jonselling
Copy link

I was hoping this feature would be in ROS 2, is there any plans to merge this in or get it looked at again?

@esteve
Copy link
Member

esteve commented Apr 10, 2024

@Arnatious @nuclearsandwich is there anything else that needs to be addressed for this PR? It'd be a great functionality for the ros2 cli. Thanks.

@quantumxt
Copy link

Is there any update on this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ros2 Issues and PRs relating to ROS 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.