Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMakeLists.txt #79

Closed
wants to merge 1 commit into from
Closed

Update CMakeLists.txt #79

wants to merge 1 commit into from

Conversation

mosfet80
Copy link

switch to cmake v3.8 required form ros iron

@mosfet80
Update CMakeLists.txt
6866a81 
switch to cmake v3.8 required form ros iron
clalancette
clalancette requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do the update to kdl_parser_py right now.

While this is certainly a problem with this package, it is not the only problem. In particular we need to solve #46/merge #55, at which point we'll have to do this as a pre-requisite.

@clalancette
Copy link
Collaborator

Given my previous comment, I'm going to go ahead and close this. This will get done as part of the larger work to port kdl_parser_py to ROS 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mosfet80 @clalancette