tf2_eigen: Deprecate methods using Affine3d. #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests pass, but compiling them issues deprecation warnings because they're still testing the newly deprecated functions. |
tfoote
requested changes
Apr 30, 2019
There was a problem hiding this comment.
This looks fine but we should switch the test cases before merging this. And for deprecating API's we'd need to target the changes into noetic and not pull them out from under people on the current release.
We haven't yet forked for noetic, but I'll add the milestone to keep track of this.
|
This PR is targeting a EOL distribution melodic, closing this PR, feel free to reopen this against a maintained branch |
|
Continued in #561. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in #358 .