Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common_diagnostics CPU monitoring fails on hostname with added domain #404

Open
sjusner opened this issue Nov 7, 2024 · 1 comment · May be fixed by #405
Open

common_diagnostics CPU monitoring fails on hostname with added domain #404

sjusner opened this issue Nov 7, 2024 · 1 comment · May be fixed by #405
Assignees
@ct2034
Labels
bug This is a bug in the code (and not a new feature) ros2 PR tackling a ROS2 branch

Comments

@sjusner
Copy link

sjusner commented Nov 7, 2024

The hostname generated by socket.gethostname() can contain non-alphanumeric symbols, e.g. when a domain is added: hostname.domain.com
Currently, the cpu, ram and sensor monitoring fail due to incomplete string sanitation.

Solution:
Better string sanitation for all common_diagnostics nodes (also adds more consistent behavior)
@sjusner sjusner linked a pull request Nov 7, 2024 that will close this issue
Open
@ct2034
Copy link
Collaborator

ct2034 commented Dec 3, 2024

Thanks for reporting the bug. I will look into this

@ct2034 ct2034 self-assigned this Dec 3, 2024
@ct2034 ct2034 added bug This is a bug in the code (and not a new feature) ros2 PR tackling a ROS2 branch labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ct2034 ct2034

Labels
bug This is a bug in the code (and not a new feature) ros2 PR tackling a ROS2 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

common_diagnostics cleaned hostname string sjusner/diagnostics
2 participants
@ct2034 @sjusner