Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a FindYamlCpp.cmake #30

Open
vrabaud opened this issue Feb 14, 2015 · 3 comments
Open

provide a FindYamlCpp.cmake #30

vrabaud opened this issue Feb 14, 2015 · 3 comments

Comments

@vrabaud
Copy link
Member

vrabaud commented Feb 14, 2015

seems useful after:
ros-perception/image_common#31

(plus, there were already problems between 0.3 and 0.5)

There is an open issue upstream:
https://code.google.com/p/yaml-cpp/issues/detail?id=127

Even though there is some CMake code here:
https://code.google.com/p/yaml-cpp/source/browse/

Should we comply to their notation ? YAML_CPP_INCLUDE_DIR and not YAML_CPP_INCLUDE_DIRS

@vrabaud
Copy link
Member Author

vrabaud commented Feb 21, 2015

Proof of concept that works for me here: #31

@wjwwood
Copy link
Member

wjwwood commented Feb 21, 2015

Ok, I'll have a look tomorrow. Sorry for the delay, this got lost in my inbox noise.

@wjwwood
Copy link
Member

wjwwood commented Feb 23, 2015

We can have a FindYAMLCpp.cmake, but we should fix the logic so it actually makes sense first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants