You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
as the brew install yaml-cpp-0.3 command links the libraries properly (as does brew install yaml-cpp which is the 0.5 version, for that matter). (Yosemite, indigo).
Without those lines, it works even with yaml-cpp 0.5 verison which is now standard.
I agree with removing those lines as they look unnecessary now.
These lines were added because there isn't a FindYamlCpp.cmake back then (see issue ros/cmake_modules#30). If you look at #31, you will find that PR adds a FindYamlCpp.cmake that will work with Mac OS. With that, the same cmake logic should work for both Linux and Mac.
I think these lines are no longer necessary:
https://github.com/ros-perception/image_common/blob/hydro-devel/camera_calibration_parsers/CMakeLists.txt#L18-L22
as the
brew install yaml-cpp-0.3
command links the libraries properly (as doesbrew install yaml-cpp
which is the 0.5 version, for that matter). (Yosemite, indigo).Without those lines, it works even with yaml-cpp 0.5 verison which is now standard.
This is the issue referenced here: http://wiki.ros.org/jade/Installation/OSX/Homebrew/Source#os.2BAC8-OSX.2BAC8-Homebrew.2BAC8-troubleshooting.camera_calibration_parsers_build_problems
and is one of the reasons we've had to keep yaml 0.3 around even though 0.5 is the new standard.
I'll make a pull request into hydro-devel if this seems reasonable?
The text was updated successfully, but these errors were encountered: