-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper functions for creating OS specific library names #29
Conversation
+1 |
Add helper functions for creating OS specific library names
Locally the test fails for me when being build in a ROS 2 workspace with the following error:
|
But the |
@dirk-thomas That's strange, are you sure that you had this branch checkout at that point? The CI job passed: https://travis-ci.org/ros/class_loader/jobs/87561847 Do you see anything obvious that I might be doing wrong/differently from your local system that might cause that? https://github.com/ros/class_loader/blob/ros2/.travis.yml I'll try it in my local vm. |
I just tested this on my Trusty VM, but I cannot reproduce it. Can you try again? |
I reran the tests in my local workspace and the tests still fail with the same error. |
I believe it's because you're building as Debug, so it is appending |
This won't always work (depending on how people build their plugin libraries), but it should allow for less code in the default case.