Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper functions for creating OS specific library names #29

Merged
merged 6 commits into from
Oct 26, 2015

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Oct 26, 2015

This won't always work (depending on how people build their plugin libraries), but it should allow for less code in the default case.

@dirk-thomas
Copy link
Member

+1

wjwwood added a commit that referenced this pull request Oct 26, 2015
Add helper functions for creating OS specific library names
@wjwwood wjwwood merged commit 9ffe626 into ros2 Oct 26, 2015
@esteve esteve removed the in review label Oct 26, 2015
@wjwwood wjwwood deleted the ros2_os_agnostic_library_names branch October 26, 2015 23:09
@dirk-thomas
Copy link
Member

Locally the test fails for me when being build in a ROS 2 workspace with the following error:

/home/dthomas/ros/ros2/ws_ros2/src/ros2/class_loader/test/fviz_case_study/fviz_test.cpp:17
Failed
ClassLoaderException: Could not load library (Poco exception = libclass_loader_Test_FvizDefaultPlugind.so: cannot open shared object file: No such file or directory)

@dirk-thomas
Copy link
Member

But the utest also fails for me in that case which might be related.

@wjwwood
Copy link
Member Author

wjwwood commented Nov 12, 2015

@dirk-thomas That's strange, are you sure that you had this branch checkout at that point? The CI job passed: https://travis-ci.org/ros/class_loader/jobs/87561847

Do you see anything obvious that I might be doing wrong/differently from your local system that might cause that? https://github.com/ros/class_loader/blob/ros2/.travis.yml

I'll try it in my local vm.

@wjwwood
Copy link
Member Author

wjwwood commented Nov 12, 2015

I just tested this on my Trusty VM, but I cannot reproduce it. Can you try again?

@dirk-thomas
Copy link
Member

I reran the tests in my local workspace and the tests still fail with the same error.

@wjwwood
Copy link
Member Author

wjwwood commented Nov 12, 2015

I believe it's because you're building as Debug, so it is appending d.so instead of .so. This is something that Poco does, which I think it incorrect. I'll open a ticket to track the issue and look into the appropriate solution: #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants