Fix ternary null check found by clang static analysis #176
Conversation
Signed-off-by: Stephen Brawner <[email protected]>
|
This PR will need to be backported to relevant branches. |
brawner
force-pushed
the
brawner/fix-ternary-null-check
branch
2 times, most recently
from
74fc1f2 to
7a2335a
Compare
|
Running on just ci.ros2.org for now, I'll have to rebase and merge this commit as it includes some fixes for travis/appveyor. Testing
|
brawner
force-pushed
the
brawner/fix-ternary-null-check
branch
2 times, most recently
from
02e9a39 to
c4d8ac1
Compare
|
@clalancette I don't think the travis and appveyor jobs are gonig to work with just simple updates to travis/appveyor configs. The Rpr job succeeds, and the CI jobs succeeded. The windows job shows some warnings about deprecations of cmake versions which we'll need to address elsewhere and are unrelated to this PR. I dont' have merge privlegeges, are you able to merge it? I removed the commit for travis/appveyor updates so this can be squash merged |
|
I'll go ahead and merge it. @brawner Can you open an issue to look into fixing the Travis and Appveyor jobs? It looks like they've been consistently failing since June. |
|
See #164 |
This null check logic is backwards. This was easily found by scan-build from clang static analysis. After this PR, class_loader builds cleanly with scan-build.
Signed-off-by: Stephen Brawner [email protected]