Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YUV420 conversions to cv_bridge #360

Conversation

luca-della-vedova
Copy link
Contributor

@luca-della-vedova luca-della-vedova commented Sep 2, 2020

This PR introduces support for YUV420 (or I420) conversions to cv_bridge.
YUV420 has 12 bits per pixel, this is represented in cv::Mat objects as a one channel image with 1.5 times the number of rows.

To be tested with / merged after the matching PR in common_msgs.

It was tested with the following pipeline:
gstreamer pipeline -> OpenCV VideoCap object -> cv_bridge + image_transport -> rqt_image_view

Signed-off-by: Luca Della Vedova <[email protected]>
@atasoglou
Copy link

atasoglou commented Dec 8, 2020

Hey @luca-della-vedova,
Thanks for the contribution. We wanted to try this out quickly with noetic (Ubuntu 20.04) but it is not compiling for us. CMake had issues with boost_python3 which we quickly "fixed" but then we noticed also this expects OpenCV 3 while the default for Ubuntu 20.04 is OpenCV 4. Using OpenCV4 it doesn't compile.

Any ideas/clues? Thanks!

Update: We just cloned the latest noetic branch and used your changes and it compiles. We now are checking if works.

@ijnek
Copy link
Member

ijnek commented Sep 7, 2022

Hi @luca-della-vedova, I've recently become the maintinaer of this repo, and I'm going through the list of PRs to figure out which ones are still active and important.

I'm going to close this PR out as I believe it is now stale, but if anyone thinks these changes are still relevant, please comment on this PR and we can get it re-opened.

@ijnek ijnek closed this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants