Fix resolving sub-namespaces incorrectly #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, there seems to be an issue with sub node creates or the effective namespace when there is no sub-namespace. For example when I create a subnode with an empty sub-namspace as an argument. I get the same error. |
|
The namespace error should be resolved with ros2/rclcpp#1656. But for now I am adding a check that removes any trailing slash. |
devrite
force-pushed
the
fix/187-image_transport-does-not-resolve
branch
from
bddac70 to
d2275bc
Compare
Signed-off-by: Markus Hofstaetter <[email protected]>
devrite
force-pushed
the
fix/187-image_transport-does-not-resolve
branch
from
d2275bc to
2184483
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187 using
get_effective_namespaceinstead. The newresolve_topic_namein the node topic interface is only available in rolling as far as i can tell.