Skip to content

Commit

Permalink
Switch to using the override keyword for simple_publisher_plugin. (#285)
Browse files Browse the repository at this point in the history
This resolves a warning pointed out by building with
clang.

Signed-off-by: Chris Lalancette <[email protected]>
  • Loading branch information
clalancette authored Aug 28, 2023
1 parent 17711d4 commit 0d46b47
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -65,21 +65,21 @@ class SimplePublisherPlugin : public PublisherPlugin
public:
virtual ~SimplePublisherPlugin() {}

virtual size_t getNumSubscribers() const
size_t getNumSubscribers() const override
{
if (simple_impl_) {
return simple_impl_->pub_->get_subscription_count();
}
return 0;
}

virtual std::string getTopic() const
std::string getTopic() const override
{
if (simple_impl_) {return simple_impl_->pub_->get_topic_name();}
return std::string();
}

virtual void publish(const sensor_msgs::msg::Image & message) const
void publish(const sensor_msgs::msg::Image & message) const override
{
if (!simple_impl_ || !simple_impl_->pub_) {
auto logger = simple_impl_ ? simple_impl_->logger_ : rclcpp::get_logger("image_transport");
Expand All @@ -92,7 +92,7 @@ class SimplePublisherPlugin : public PublisherPlugin
publish(message, bindInternalPublisher(simple_impl_->pub_.get()));
}

virtual void shutdown()
void shutdown() override
{
simple_impl_.reset();
}
Expand Down

0 comments on commit 0d46b47

Please sign in to comment.